Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty stats models #965

Merged
merged 4 commits into from Jul 22, 2021
Merged

Fix empty stats models #965

merged 4 commits into from Jul 22, 2021

Conversation

rwblair
Copy link
Collaborator

@rwblair rwblair commented Jul 21, 2021

fixes #962

@cypress
Copy link

cypress bot commented Jul 21, 2021



Test summary

7 0 0 0Flakiness 1


Run details

Project Neuroscout
Status Passed
Commit d12aeaa ℹ️
Started Jul 21, 2021 11:15 PM
Ended Jul 21, 2021 11:17 PM
Duration 02:00 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/analysis_builder.spec.js Flakiness
1 Analysis Builder > analysis builder

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2021

Codecov Report

Merging #965 (a9f87dd) into master (24c8772) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #965   +/-   ##
=======================================
  Coverage   82.69%   82.69%           
=======================================
  Files          63       63           
  Lines        3132     3132           
=======================================
  Hits         2590     2590           
  Misses        542      542           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c8772...a9f87dd. Read the comment docs.

@cypress
Copy link

cypress bot commented Jul 21, 2021



Test summary

7 0 0 0Flakiness 1


Run details

Project Neuroscout
Status Passed
Commit a9f87dd
Started Jul 21, 2021 11:15 PM
Ended Jul 21, 2021 11:17 PM
Duration 01:48 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/analysis_builder.spec.js Flakiness
1 Analysis Builder > analysis builder

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@adelavega
Copy link
Collaborator

Test on production backend to compare against problematic model

@adelavega
Copy link
Collaborator

LGTM, tested on prod

@adelavega adelavega merged commit e6f49ac into master Jul 22, 2021
@adelavega adelavega deleted the fix_empty_stats_models branch September 22, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cold load of "narratives" analysis -- wrong ID for report
3 participants