Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont add runs to bids model if all runids selected. #971

Merged
merged 1 commit into from Aug 3, 2021

Conversation

rwblair
Copy link
Collaborator

@rwblair rwblair commented Aug 3, 2021

fixes #968

@cypress
Copy link

cypress bot commented Aug 3, 2021



Test summary

7 0 0 0Flakiness 1


Run details

Project Neuroscout
Status Passed
Commit 1dd3870 ℹ️
Started Aug 3, 2021 10:50 PM
Ended Aug 3, 2021 10:52 PM
Duration 01:44 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/analysis_builder.spec.js Flakiness
1 Analysis Builder > analysis builder

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Aug 3, 2021



Test summary

7 0 0 0Flakiness 1


Run details

Project Neuroscout
Status Passed
Commit 53500ac
Started Aug 3, 2021 9:10 PM
Ended Aug 3, 2021 9:12 PM
Duration 02:00 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/analysis_builder.spec.js Flakiness
1 Analysis Builder > analysis builder

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@adelavega
Copy link
Collaborator

LGTM! Thanks!

@adelavega adelavega merged commit 9118421 into master Aug 3, 2021
@adelavega adelavega deleted the 968_null_run_in_model branch August 3, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop runs from BIDS Stats Model if no runs are excluded
2 participants