Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix demographics #989

Merged
merged 5 commits into from Sep 28, 2021
Merged

Fix demographics #989

merged 5 commits into from Sep 28, 2021

Conversation

adelavega
Copy link
Collaborator

Fix #986

Bug in computing mean age caused all ages to be displayed as n/a

@cypress
Copy link

cypress bot commented Sep 28, 2021



Test summary

7 0 0 0Flakiness 1


Run details

Project Neuroscout
Status Passed
Commit ed86730
Started Sep 28, 2021 7:56 PM
Ended Sep 28, 2021 7:58 PM
Duration 02:06 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/analysis_builder.spec.js Flakiness
1 Analysis Builder > analysis builder

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Sep 28, 2021



Test summary

7 0 0 0Flakiness 1


Run details

Project Neuroscout
Status Passed
Commit 90a9f18 ℹ️
Started Sep 28, 2021 7:58 PM
Ended Sep 28, 2021 8:00 PM
Duration 01:58 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/analysis_builder.spec.js Flakiness
1 Analysis Builder > analysis builder

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov-commenter
Copy link

Codecov Report

Merging #989 (ed86730) into master (8511c4f) will decrease coverage by 0.16%.
The diff coverage is 9.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #989      +/-   ##
==========================================
- Coverage   78.58%   78.41%   -0.17%     
==========================================
  Files          63       63              
  Lines        3231     3238       +7     
==========================================
  Hits         2539     2539              
- Misses        692      699       +7     
Impacted Files Coverage Δ
neuroscout/models/dataset.py 71.15% <9.09%> (-11.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8511c4f...ed86730. Read the comment docs.

@adelavega adelavega merged commit cfb820c into master Sep 28, 2021
@adelavega adelavega deleted the fix_demographics branch September 28, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Most datasets lack meta data
2 participants