Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep track of all cli_args for neurovault upload #995

Merged
merged 5 commits into from Oct 13, 2021
Merged

Conversation

adelavega
Copy link
Collaborator

Ideally, this would just keep track of all fitlins args, but for now keeps track of all arguments passed to neuroscout cli (including defaults)

Might want to blacklist some sensitive items such as directories, and in the future may want to get full list of args (including all fitlins defaults), rather than just set by neuroscout-cli

@cypress
Copy link

cypress bot commented Oct 12, 2021



Test summary

7 0 0 0Flakiness 1


Run details

Project Neuroscout
Status Passed
Commit 3891b55 ℹ️
Started Oct 13, 2021 7:28 PM
Ended Oct 13, 2021 7:29 PM
Duration 01:43 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/analysis_builder.spec.js Flakiness
1 Analysis Builder > analysis builder

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2021

Codecov Report

Merging #995 (42e0943) into master (95083c4) will decrease coverage by 0.03%.
The diff coverage is 66.66%.

❗ Current head 42e0943 differs from pull request most recent head 32e8886. Consider uploading reports for the commit 32e8886 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #995      +/-   ##
==========================================
- Coverage   78.41%   78.37%   -0.04%     
==========================================
  Files          63       63              
  Lines        3238     3246       +8     
==========================================
+ Hits         2539     2544       +5     
- Misses        699      702       +3     
Impacted Files Coverage Δ
neuroscout/resources/analysis/reports.py 52.34% <57.14%> (-0.10%) ⬇️
neuroscout/models/analysis.py 97.33% <100.00%> (+0.03%) ⬆️
neuroscout/schemas/analysis.py 97.64% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95083c4...32e8886. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants