Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nv indicator in analysis list #998

Merged
merged 22 commits into from Nov 2, 2021
Merged

Conversation

rwblair
Copy link
Collaborator

@rwblair rwblair commented Oct 19, 2021

Also fixes #980

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2021

Codecov Report

Merging #998 (b9f788b) into master (95083c4) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #998      +/-   ##
==========================================
- Coverage   78.41%   78.36%   -0.05%     
==========================================
  Files          63       63              
  Lines        3238     3250      +12     
==========================================
+ Hits         2539     2547       +8     
- Misses        699      703       +4     
Impacted Files Coverage Δ
neuroscout/resources/analysis/endpoints.py 88.67% <ø> (ø)
neuroscout/resources/user.py 74.39% <ø> (ø)
neuroscout/models/analysis.py 97.40% <100.00%> (+0.10%) ⬆️
neuroscout/schemas/analysis.py 97.67% <100.00%> (+0.05%) ⬆️
neuroscout/resources/analysis/reports.py 52.00% <0.00%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95083c4...b9f788b. Read the comment docs.

@cypress
Copy link

cypress bot commented Oct 19, 2021



Test summary

7 0 0 0Flakiness 1


Run details

Project Neuroscout
Status Passed
Commit e9d421a ℹ️
Started Oct 27, 2021 8:30 PM
Ended Oct 27, 2021 8:31 PM
Duration 01:02 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/analysis_builder.spec.js Flakiness
1 Analysis Builder > analysis builder

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@adelavega
Copy link
Collaborator

@rwblair can you take look at the failing test?

@rwblair
Copy link
Collaborator Author

rwblair commented Oct 27, 2021

@adelavega gottem coach

@adelavega adelavega merged commit b9154fc into master Nov 2, 2021
@adelavega adelavega deleted the nv_indicator_in_analysis_list branch November 2, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run page typo
3 participants