New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add save()
and load()
methods to MetaResult
objects
#771
Conversation
Codecov ReportBase: 88.66% // Head: 88.65% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #771 +/- ##
==========================================
- Coverage 88.66% 88.65% -0.02%
==========================================
Files 38 39 +1
Lines 4323 4327 +4
==========================================
+ Hits 3833 3836 +3
- Misses 490 491 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but does get_params still work with a MetaResult object?
I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this change, but can you add the new methods to one of the tests?
Thanks! I've added the test to |
this looks good to merge. |
Closes #770.
Changes proposed in this pull request: