Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add save() and load() methods to MetaResult objects #771

Merged
merged 4 commits into from
Feb 21, 2023
Merged

Add save() and load() methods to MetaResult objects #771

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9772f2c
Add save() and load() methods to MetaResult objects
JulioAPeraza Feb 13, 2023
f4ac4e1
Fix circular import error
JulioAPeraza Feb 13, 2023
30b9c9e
Add estimator module to fix circular import error
JulioAPeraza Feb 14, 2023
4703d5e
Add test saving/loading MetaResult object
JulioAPeraza Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions nimare/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
from abc import ABCMeta, abstractmethod
from collections import defaultdict

from nimare.results import MetaResult

LGR = logging.getLogger(__name__)


Expand Down Expand Up @@ -326,6 +324,8 @@ def fit(self, dataset, drop_invalid=True):
"fitting" methods are implemented as `_fit`, although users should
call `fit`.
"""
from nimare.results import MetaResult

self._collect_inputs(dataset, drop_invalid=drop_invalid)
self._preprocess_input(dataset)
maps, tables = self._fit(dataset)
Expand Down
3 changes: 2 additions & 1 deletion nimare/results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,13 @@
import pandas as pd
from nibabel.funcs import squeeze_image

from nimare.base import NiMAREBase
from nimare.utils import get_masker

LGR = logging.getLogger(__name__)


class MetaResult(object):
class MetaResult(NiMAREBase):
"""Base class for meta-analytic results.

Parameters
Expand Down