Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the NeuroLibre badge #824

Merged
merged 2 commits into from Aug 22, 2023
Merged

Fix the NeuroLibre badge #824

merged 2 commits into from Aug 22, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Aug 17, 2023

Closes none.

Changes proposed in this pull request:

  • Fix the NeuroLibre preprint badges in the RTD pages and README.
  • Address style issues in tests.

@tsalo tsalo added the documentation Improving documentation for the project label Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e59a083) 88.68% compared to head (1bb5b5a) 88.68%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #824   +/-   ##
=======================================
  Coverage   88.68%   88.68%           
=======================================
  Files          47       47           
  Lines        6026     6026           
=======================================
  Hits         5344     5344           
  Misses        682      682           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo
Copy link
Member Author

tsalo commented Aug 18, 2023

I think the RTD failure is unrelated.

Copy link
Collaborator

@JulioAPeraza JulioAPeraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I think the issue in the RTD build it's related to sphinx>=7, and it should be solved now that sphinx_rtd_theme=1.3.0 was released.

@JulioAPeraza JulioAPeraza mentioned this pull request Aug 22, 2023
@jdkent jdkent merged commit 498396d into neurostuff:main Aug 22, 2023
18 of 19 checks passed
@jdkent
Copy link
Member

jdkent commented Aug 22, 2023

LGTM, thanks @tsalo!

@jdkent jdkent mentioned this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improving documentation for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants