New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IBMAWorkflow #817
Add IBMAWorkflow #817
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #817 +/- ##
==========================================
+ Coverage 88.67% 88.91% +0.24%
==========================================
Files 47 48 +1
Lines 6020 6125 +105
==========================================
+ Hits 5338 5446 +108
+ Misses 682 679 -3
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one question in the example notebook
It looks like an epsilon that small does not solve the issue. I think we would need a higher threshold so that the coverage maps are not 1 in all the voxels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, would the workflow to try to handle transformations, and raise an error if there isn't the right data to do the transformations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for all your work on this!
Closes None.
Changes proposed in this pull request: