Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #28
@tyarkoni: should the
nimads_data
dictionary be nested and contain all the analysis information, images, points information or should the dictionary merely be a pointer to a list of study ids?If the nimads_data dataset is nested then the information should be self-contained in the dataset, but all the data will essentially be copied over, meaning if the data is changed on the database then the changes will not be propagated to the nimads_data dictionary.
e.g.
If the dataset is just a list of study ID's, then the dataset may change depending on updates to the database, and the client library will handle resolving the study ID's into their actual representations.
e.g.
It sounds like I want the first option since we want datasets to be immutable (and that's what presented in #28), but I could see the motivation for just a list of Study IDs since it's more compact representation.