Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] post/get datasets #29

Merged
merged 8 commits into from
Apr 15, 2021
Merged

Conversation

jdkent
Copy link
Member

@jdkent jdkent commented Apr 14, 2021

ref #28
@tyarkoni: should the nimads_data dictionary be nested and contain all the analysis information, images, points information or should the dictionary merely be a pointer to a list of study ids?

If the nimads_data dataset is nested then the information should be self-contained in the dataset, but all the data will essentially be copied over, meaning if the data is changed on the database then the changes will not be propagated to the nimads_data dictionary.
e.g.

{
    "dataset": [{"analysis": [...], "name": ..., ...}, {"analysis": [...], "name": ..., ...}]
}

If the dataset is just a list of study ID's, then the dataset may change depending on updates to the database, and the client library will handle resolving the study ID's into their actual representations.
e.g.

{
    "dataset": ["sldkfnejfne", "erfewrgrtrt", "apofiermkgt"]
}

It sounds like I want the first option since we want datasets to be immutable (and that's what presented in #28), but I could see the motivation for just a list of Study IDs since it's more compact representation.

@tyarkoni
Copy link
Contributor

Yes, we want #1. The goal here is self-containment and reproducibility. Redundancy is fine, as is the existence of multiple out-of-sync versions of the same study in different datasets.

@jdkent jdkent merged commit 3b8fe9a into neurostuff:master Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants