Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior with vite's dev server #235

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

KTibow
Copy link
Contributor

@KTibow KTibow commented Jan 7, 2024

Issue: 18a2fed seems to have made it impossible for me to use frontend lib development with Vite. Even though port 5173 is connected, it just says "application will be launched when .. is ready" and eventually gives up.
Solution: Check localhost instead. The concept works in my tests with the library.

@KTibow
Copy link
Contributor Author

KTibow commented Jan 15, 2024

@shalithasuranga could you merge this? this is a big blocker for me

Copy link
Member

@shalithasuranga shalithasuranga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this contribution 🎉

@shalithasuranga shalithasuranga merged commit 7b6d8de into neutralinojs:main Jan 17, 2024
2 checks passed
@shalithasuranga
Copy link
Member

@KTibow Please check the latest release. Thanks 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants