Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix waiting for frontendlib app port #226

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Fix waiting for frontendlib app port #226

merged 1 commit into from
Nov 25, 2023

Conversation

simomat
Copy link
Contributor

@simomat simomat commented Nov 23, 2023

Fix for #223
Tested locally with my app.

@jouni-kantola jouni-kantola mentioned this pull request Nov 23, 2023
Closed
shalithasuranga
shalithasuranga approved these changes Nov 25, 2023
View reviewed changes
Copy link
Member

@shalithasuranga shalithasuranga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much your contribution 🎉

@shalithasuranga shalithasuranga merged commit 4d606d3 into neutralinojs:main Nov 25, 2023
2 checks passed
@shalithasuranga shalithasuranga mentioned this pull request Nov 25, 2023
Closed
@simomat simomat deleted the fix-frontendlib-wait-port branch November 25, 2023 07:24
@KTibow
Copy link
Contributor

KTibow commented Jan 7, 2024 •
edited
Loading

This seems to have made it impossible for me to use the dev server. Even though port 5173 is being used, it just says "application will be launched when .. is ready" and eventually gives up.

*It works if I add --host to my vite server, which I don't want to do.

@simomat
Copy link
Contributor Author

simomat commented Jan 7, 2024

I can't see how this patch could be the reason, because it only removes the hard coded port. Seems more like 18a2fed doesn't work for you somehow. (You could check by using v10.0.0 which includes 18a2fed but not this patch.)

@KTibow
Copy link
Contributor

KTibow commented Jan 7, 2024

@simomat ah nvm then, missed that. Regardless I sent in #235 to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shalithasuranga shalithasuranga shalithasuranga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simomat @KTibow @shalithasuranga