Skip to content

Commit

Permalink
Fix dynamic port issue with custom url
Browse files Browse the repository at this point in the history
  • Loading branch information
shalithasuranga committed Jun 14, 2020
1 parent a9e7bfd commit ffe2e5e
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 13 deletions.
8 changes: 3 additions & 5 deletions core-linux/src/main.cpp
Expand Up @@ -75,10 +75,6 @@ int main(int argc, char **argv)

int port = stoi(options["appport"].get<string>());
string appname = options["appname"].get<std::string>();
string navigateUrl = ("http://localhost:" + std::to_string(port) + "/" + appname);
if(!options["url"].is_null() && options["url"].get<string>() != "/")
navigateUrl = options["url"];

string mode = privileges::getMode();

int listenFd = Socket::createSocket();
Expand All @@ -101,7 +97,9 @@ int main(int argc, char **argv)
port = ntohs(sin.sin_port);
settings::setOption("appport", std::to_string(port));
}

string navigateUrl = ("http://localhost:" + std::to_string(port) + "/" + appname);
if(!options["url"].is_null() && options["url"].get<string>() != "/")
navigateUrl = options["url"];
Socket::Listen(listenFd);

if (mode == "browser")
Expand Down
8 changes: 4 additions & 4 deletions core-macos/src/main.cpp
Expand Up @@ -84,10 +84,6 @@ int main(int argc, char **argv)

int port = stoi(options["appport"].get<string>());
string appname = options["appname"].get<std::string>();
string navigateUrl = ("http://localhost:" + std::to_string(port) + "/" + appname);
if(!options["url"].is_null() && options["url"].get<string>() != "/")
navigateUrl = options["url"];

string mode = privileges::getMode();

int listenFd = Socket::createSocket();
Expand All @@ -109,6 +105,10 @@ int main(int argc, char **argv)
settings::setOption("appport", std::to_string(port));
}

string navigateUrl = ("http://localhost:" + std::to_string(port) + "/" + appname);
if(!options["url"].is_null() && options["url"].get<string>() != "/")
navigateUrl = options["url"];

Socket::Listen(listenFd);

if(mode == "browser") {
Expand Down
8 changes: 4 additions & 4 deletions core-windows/src/serverlistener.cpp
Expand Up @@ -63,10 +63,6 @@ void ServerListener::run(std::function<void(ClientAcceptationException)> client_
json options = settings::getOptions();
string appname = options["appname"];
string appport = options["appport"];
string navigateUrl = "http://localhost:" + appport + "/" + appname;
if(!options["url"].is_null() && options["url"].get<string>() != "/")
navigateUrl = options["url"];

string mode = privileges::getMode();
this->port = stoi(appport);

Expand Down Expand Up @@ -104,6 +100,10 @@ void ServerListener::run(std::function<void(ClientAcceptationException)> client_
settings::setOption("appport", std::to_string(port));
appport = std::to_string(port);
}
string navigateUrl = "http://localhost:" + appport + "/" + appname;
if(!options["url"].is_null() && options["url"].get<string>() != "/")
navigateUrl = options["url"];


if(listen(listen_socket, SOMAXCONN) == SOCKET_ERROR) {
closesocket(listen_socket);
Expand Down

0 comments on commit ffe2e5e

Please sign in to comment.