Merge pull request #199 from neutrinoceros/rfc/no_protocols

RFC: drop misleading use of typing.Protocol
neutrinoceros · May 23, 2024 · a131415 · a131415
2 parents c642629 + ee65e5c
commit a131415
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/gpgi/types.py b/src/gpgi/types.py
@@ -10,7 +10,7 @@
 from functools import cached_property, partial, reduce
 from itertools import chain
 from time import monotonic_ns
-from typing import TYPE_CHECKING, Any, Literal, Protocol, cast
+from typing import TYPE_CHECKING, Any, Literal, cast
 
 import numpy as np
 
@@ -109,12 +109,12 @@ class DepositionMethod(enum.Enum):
 }
 
 
-class GeometricData(Protocol):
+class GeometricData(ABC):
     geometry: Geometry
     axes: tuple[Name, ...]
 
 
-class CoordinateData(Protocol):
+class CoordinateData(ABC):
     geometry: Geometry
     axes: tuple[Name, ...]
     coordinates: FieldMap