This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
mocha: Use correct function for merging lint configuration #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The refactor in #1182 inadvertently used babel-merge's `merge()` to merge ESLint configuration in this preset rather than deepmerge, since the existing `merge` import was not the same as in other presets from which the lint rule merging block was copied. In a later PR I think we should stop exporting a merge function from `@neutrinojs/compile-loader` named `merge`, to avoid the reduce the chance of this kind of naming conflict. Fixes: taskcluster/taskcluster-web-server#59 (comment)
helfi92
approved these changes
Nov 23, 2018
|
@edmorley Any idea when this will be published? |
|
Publishing new releases of the monorepo is pretty broken on Windows at the moment, so I've been leaving it to Eli to publish new versions. Happy to have a new beta published whenever :-) |
|
A new beta sounds good to me :) |
edmorley
added a commit
that referenced
this pull request
Nov 26, 2018
Since it's no longer a custom implementation and instead just the `babel-merge` package exported. As such it makes more sense for packages to import `babel-merge` directly iff they need it. This also avoids the naming clash between `merge` from this preset and the typical import style used for `deepmerge` in this repository, that contributed to the bug fixed by #1219.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactor in #1182 inadvertently used babel-merge's
merge()to merge ESLint configuration in this preset rather than deepmerge, since the existingmergeimport was not the same as in other presets from which the lint rule merging block was copied.In a later PR I think we should stop exporting a merge function from
@neutrinojs/compile-loadernamedmerge, to avoid the reduce the chance of this kind of naming conflict.Fixes:
taskcluster/taskcluster-web-server#59 (comment)