Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Update dependency yargs-parser to v20 #1619

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 9, 2020

This PR contains the following updates:

Package Type Update Change
yargs-parser dependencies major ^19.0.4 -> ^20.0.0

Release Notes

yargs/yargs-parser

v20.0.0

Compare Source

⚠ BREAKING CHANGES
  • do not ship type definitions (#​318)
Bug Fixes
Code Refactoring
19.0.4 (2020-08-27)
Bug Fixes
19.0.3 (2020-08-27)
Bug Fixes
19.0.2 (2020-08-27)
Bug Fixes
19.0.1 (2020-08-09)
Bug Fixes
  • build: push tag created for deno (2186a14)

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@edmorley edmorley added the bug label Sep 11, 2020
@renovate renovate bot force-pushed the renovate/yargs-parser-20.x branch from 236e209 to e427229 Compare September 11, 2020 22:38
@edmorley edmorley merged commit 4859a00 into master Sep 11, 2020
@edmorley edmorley deleted the renovate/yargs-parser-20.x branch September 11, 2020 22:57
@davidje13
Copy link
Contributor

Is it possible to get a release cut with this update? yargs-parser@19 has a whole thing going on with conflicting TypeScript definitions when using Jest:

node_modules/@types/yargs/index.d.ts:28:10 - error TS2305: Module '"../../yargs-parser/build/index.cjs"' has no exported member 'DetailedArguments'.

28 import { DetailedArguments, Configuration } from 'yargs-parser';
            ~~~~~~~~~~~~~~~~~

node_modules/@types/yargs/index.d.ts:28:29 - error TS2305: Module '"../../yargs-parser/build/index.cjs"' has no exported member 'Configuration'.

28 import { DetailedArguments, Configuration } from 'yargs-parser';
                               ~~~~~~~~~~~~~

For the curious (since there isn't much info about this available and I had to spend a lot of time investigating), yargs-parser@19 switched (possibly accidentally) to including its own definitions rather than using @types/yargs-parser, but the @types/yargs package still depends on @types/yargs-parser rather than yargs-parser. If found, the yargs-parser types will take priority over the @types/yargs-parser ones. That combined with NPM's package hoisting means that if there are 2 versions of yargs-parser installed, which one it finds is basically random (the lack of a direct dependency means it won't force it to a particular version for that part of the dependency tree). In yargs-parser@20 it works because they got rid of bundling types in the main project and went back to using the @types/yargs-parser package (yargs/yargs-parser@8fbd56f).

It's a interesting frustrating example of how DefinitelyTyped's packaging strategy and NPM's package hoisting strategy can in rare situations (when types migrate from living with the project to living on @types or vice-versa) combine to cause an incredible mess.

@edmorley
Copy link
Member

@davidje13 Hi :-) That sounds like a pain! I've published Neutrino v9.5.0 which contains this update. Hope it helps!

@davidje13
Copy link
Contributor

Yep, all working again now. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants