This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Add supported versions of npm, Yarn and Node.js #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helfi92
force-pushed
the
update-versions
branch
from
a6b2a89
to
2708c3d
Compare
eliperelman
reviewed
Dec 19, 2017
package.json
Outdated
| @@ -7,8 +7,9 @@ | |||
| "bugs": "https://github.com/mozilla-neutrino/neutrino-dev/issues", | |||
| "repository": "mozilla-neutrino/neutrino-dev", | |||
| "engines": { | |||
| "node": ">=6.10.0", | |||
| "yarn": "^1.2.1" | |||
| "node": ">=6.9.0", | |||
There was a problem hiding this comment.
The node engine needs to be more complex to handle the actual support. I think you can use || to delineate these. Also, since 7 is excluded, we probably don't want >= except in the 9 case.
"node": "^6.9.0 || ^8 || >=9"
There was a problem hiding this comment.
I'm pretty sure the ^8 can be written as 8 (the latter being what I've seen used elsewhere).
There was a problem hiding this comment.
I haven't seen that, but I think sticking with the ^ makes the semver relationship clearer.
eliperelman
approved these changes
Dec 21, 2017
timkelty
pushed a commit
that referenced
this pull request
Dec 21, 2017
* Update packages in docs directory with new requirements * Update every monorepo package.json's engines * Update packages in packages directory with new requirements * Add missed requirements in docs directory * Modify node engine to be ^6.9.0 || ^8 || >=9
timkelty
pushed a commit
to timkelty/neutrino
that referenced
this pull request
Jan 17, 2018
* Update packages in docs directory with new requirements * Update every monorepo package.json's engines * Update packages in packages directory with new requirements * Add missed requirements in docs directory * Modify node engine to be ^6.9.0 || ^8 || >=9
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #625.