This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Fix npmsearchlist #654
Merged
Fix npmsearchlist #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliperelman
reviewed
Jan 4, 2018
| @@ -22,4 +22,4 @@ In addition, your middleware should also: | |||
| It should also have a relevant description. If you prefer, you can also add your middleware to the | |||
| [neutrino-dev wiki](https://github.com/mozilla-neutrino/neutrino-dev/wiki/Community-Middleware). | |||
|
|
|||
| {% npmsearchlist "keywords:neutrino-middleware+not:deprecated" %}{% endnpmsearchlist %} | |||
| {% npmsearchlist "keywords:neutrino-middleware not:deprecated" %}{% endnpmsearchlist %} | |||
There was a problem hiding this comment.
Let's URL-encode these with %20s.
eliperelman
reviewed
Jan 5, 2018
| @@ -22,4 +22,4 @@ In addition, your middleware should also: | |||
| It should also have a relevant description. If you prefer, you can also add your middleware to the | |||
| [neutrino-dev wiki](https://github.com/mozilla-neutrino/neutrino-dev/wiki/Community-Middleware). | |||
|
|
|||
| {% npmsearchlist "keywords:neutrino-middleware+not:deprecated" %}{% endnpmsearchlist %} | |||
| {% npmsearchlist "keywords:neutrino-middleware%20snot:deprecated" %}{% endnpmsearchlist %} | |||
There was a problem hiding this comment.
This should just be %20 not %20s.
timkelty
added a commit
to timkelty/neutrino
that referenced
this pull request
Jan 17, 2018
…s#654) * Fix npmsearchlist * Encode spaces * Fix typo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #653
I'm guessing maybe npms.io changed how they encode spaces?
Probably want to change README in https://github.com/eliperelman/gitbook-plugin-npmsearchlist#usage as well.