Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Create index.d.ts #123

Closed
wants to merge 1 commit into from
Closed

Create index.d.ts #123

wants to merge 1 commit into from

Conversation

Jetsly
Copy link
Contributor

@Jetsly Jetsly commented Nov 14, 2018

#62
Copy from

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/webpack-chain/index.d.ts

add

mode(value: 'development' | 'production') : this;
parallelism(value: number) : this;

modify

minimizer(value: webpack.Plugin[]): this;
=>
minimizer(name: string): Config.Plugin<this>;

Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you for the PR.

I'm definitely open to the idea of adding type definitions, however we'll want to make sure they are tested on Travis so PRs don't accidentally break them at a later point.

Also, what are your thoughts on changing this to use the code comment type form and then have the build extract the types to the .d.ts file?

@Jetsly
Copy link
Contributor Author

Jetsly commented Nov 20, 2018

if write with typescript can auto extract the .d.ts file

@eliperelman
Copy link
Member

We won't be using TypeScript for the code itself.

@Jetsly Jetsly closed this Nov 22, 2018
@edmorley
Copy link
Member

Why was this closed? :-)

We'll happily accept definitions so long as tested on Travis (either as a separate definitions file, or as in-line comments if that form is supported by TypeScript, similar to flow's feature?).

@gluons
Copy link

gluons commented Dec 19, 2018

@Jetsly Why did you close this PR? 😵

@Jetsly
Copy link
Contributor Author

Jetsly commented Dec 19, 2018

i modify incomplete

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

4 participants