This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
make __expression property works in any object #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolasblack
force-pushed
the
feature/__expression-diffusion-scope
branch
2 times, most recently
from
cde9144
to
0a1b674
Compare
edmorley
approved these changes
Mar 24, 2019
There was a problem hiding this comment.
Thank you for the PR! This looks good to me - @eliperelman do you agree? :-)
eliperelman
suggested changes
Mar 24, 2019
README.md
Outdated
| stringified by setting a special `__expression` property on them: | ||
|
|
||
| ``` js | ||
| const Sass = require('sass') |
There was a problem hiding this comment.
Can you make Sass lowercase? Also, could you please put semicolons after these lines?
const sass = require('sass');
sass.__expression = `require('sass')`;
// ...
.use(MyPlugin, [{ fn: myFunction, implementation: sass, }]);
test/Config.js
Outdated
| @@ -524,6 +524,10 @@ test('toString with custom prefix', t => { | |||
|
|
|||
| test('static Config.toString', t => { | |||
| const config = new Config(); | |||
| const Sass = { | |||
bolasblack
force-pushed
the
feature/__expression-diffusion-scope
branch
from
0a1b674
to
65fa28e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because sass-loader support custom Sass implementation, and
dart-sassimplementation is an object, so I hope__expressioncan works in any object