Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fix types for Config.resolve plugins and improve Plugin types #213

Merged
merged 2 commits into from Dec 13, 2019

Conversation

opl-
Copy link
Contributor

@opl- opl- commented Dec 3, 2019

  • Fixes Config.resolve.plugin call expecting a webpack.Plugin type despite those plugins being passed an enhanced-resolve/lib/Resolver argument type. (As seen in this test which uses it as a resolve plugin)

    • All added generics default to webpack.Plugin in order to stay fully backwards compatible with previous versions.
  • Allows passing string to Plugin.use() as those get required by webpack-chain here.

  • Allows passing PluginType to Plugin.use() and Plugin.init() as the default implementation allows it.

  • Adds tests for the changes.

@opl-
Copy link
Contributor Author

opl- commented Dec 3, 2019

Force push because I didn't notice the yarn.lock and assumed packages aren't locked.

@edmorley edmorley added the bug label Dec 13, 2019
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in replying - thank you so much for fixing these! :-)

@edmorley edmorley merged commit 9d3af06 into neutrinojs:master Dec 13, 2019
@edmorley
Copy link
Member

Published in v6.1.0 :-)

@edmorley edmorley added types and removed bug labels Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants