Show OpenSSL version to --version

[metalefty]

If multiple versions of OpenSSL installed to the system, it is helpful to know which OpenSSL xrdp uses in case OpenSSL have vulnerability. Also, some cleanups and improvements.

• add OpenSSL version to --version
• use GitHub URL rather than xrdp.org, it should be more helpful
• exit with error code when unknown CLI option given
• show which CLI option is unknown to xrdp

--version

before

$ xrdp --version

xrdp: A Remote Desktop Protocol server.
Copyright (C) Jay Sorg 2004-2014
See http://www.xrdp.org for more information.
Version 0.9.5

after

$ xrdp --version
xrdp 0.9.6
  A Remote Desktop Protocol Server.
  Copyright (C) 2004-2018 Jay Sorg, Neutrino Labs, and all contributors.
  See https://github.com/neutrinolabs/xrdp for more information.

  Compiled with OpenSSL 1.0.2o  27 Mar 2018

--help

before

$ xrdp --help

xrdp: A Remote Desktop Protocol server.
Copyright (C) Jay Sorg 2004-2014
See http://www.xrdp.org for more information.

Usage: xrdp [options]
   -h, --help       show help
   -n, --nodaemon   don't fork into background
   -k, --kill       shut down xrdp
   -p, --port       tcp listen port
   -f, --fork       fork on new connection

after

$ xrdp --help
xrdp 0.9.6
  A Remote Desktop Protocol Server.
  Copyright (C) 2004-2018 Jay Sorg, Neutrino Labs, and all contributors.
  See https://github.com/neutrinolabs/xrdp for more information.

  Compiled with OpenSSL 1.0.2o  27 Mar 2018

Usage: xrdp [options]
   -h, --help       show help
   -n, --nodaemon   don't fork into background
   -k, --kill       shut down xrdp
   -p, --port       tcp listen port
   -f, --fork       fork on new connection

--unknown-option

before

$ xrdp --nodaemon --unknown-option; echo $?
Unknown Parameter
xrdp -h for help

0

after

$ xrdp --nodaemon --unknown-option; echo $?
xrdp 0.9.6
  A Remote Desktop Protocol Server.
  Copyright (C) 2004-2018 Jay Sorg, Neutrino Labs, and all contributors.
  See https://github.com/neutrinolabs/xrdp for more information.

  Compiled with OpenSSL 1.0.2o  27 Mar 2018

Usage: xrdp [options]
   -h, --help       show help
   -n, --nodaemon   don't fork into background
   -k, --kill       shut down xrdp
   -p, --port       tcp listen port
   -f, --fork       fork on new connection

Unknown option: --unknown-option
1

[jsorg71]

+1 nice

[speidy]

+1