Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy the PAM session environment for the reconnect script #1120

Merged
merged 1 commit into from Jun 14, 2018

Conversation

matt335672
Copy link
Member

In some environments, the reconnect script can benefit from access to environment variables set during the PAM session creation. For example, in a Kerberos-based environment, the reconnect script will need KRB5CCNAME to be set to make use of network services.

@metalefty
Copy link
Member

Thanks, I'll look at it. BTW, please always respect our coding standard.

Copy link
Member

@metalefty metalefty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please always respect our coding standard.

@matt335672
Copy link
Member Author

Apologies Metalefty - I'd missed the bit about spaces after commas.

I've not squashed the commits yet. Please let me know when you'd like this doing.

@metalefty
Copy link
Member

Sorry for delay. I was busy with other things. I'm still testing & looking at your PR.

BTW, squash it in this case!

This provides access to variables set at login which may be
required by the script (e.g. KRB5CCNAME)
@matt335672
Copy link
Member Author

squashed and rebased.

@metalefty metalefty added this to the v0.9.7 milestone Jun 6, 2018
@metalefty metalefty merged commit f83d967 into neutrinolabs:devel Jun 14, 2018
@matt335672 matt335672 deleted the set-env-on-reconnect branch July 19, 2018 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants