Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sesman: work on moving sesman to trans, unix domain socket #1602

Closed
wants to merge 3 commits into from

Conversation

jsorg71
Copy link
Contributor

@jsorg71 jsorg71 commented Jun 10, 2020

No description provided.

@jsorg71 jsorg71 self-assigned this Jun 10, 2020
@matt335672
Copy link
Member

I see you're returning SCP_SERVER_STATE_INTERNAL_ERR for missing data (i.e. s_check_rem() fails). Would SCP_CLIENT_STATE_SIZE_ERR / SCP_SERVER_STATE_SIZE_ERR (as appropriate) be a better choice?

I ask, as it's relevant to another change I'm looking at at the moment.

Thanks,

@jsorg71
Copy link
Contributor Author

jsorg71 commented Jun 12, 2020

@matt335672 yes, I noticed that too, I think SCP_SERVER_STATE_SIZE_ERR would be the right one. I'll change that when I push the v1 changes. Thanks.

@jsorg71 jsorg71 changed the title sesman: work on moving sesman to trans, v0 scp working sesman: work on moving sesman to trans, unix domain socket Aug 8, 2020
@matt335672
Copy link
Member

@jsorg71 - I'm quite keen to get the move to the UNIX domain socket completed, as I think it's a good idea to get this in before a fix to #1684 which is a big chunk of work.

When we've got the domain socket move done we can use something like getpeereid() for authentication for the management functions used by xrdp-sesadmin which will really help usability.

I've got some effort available at the moment. Would you be happy for me to take your sesman_trans branch and work with it?

Thanks.

@matt335672
Copy link
Member

@jsorg71 - I think we've done this one now(?)

@jsorg71
Copy link
Contributor Author

jsorg71 commented Apr 19, 2023

absolutely, thanks, I'll close this.

@jsorg71 jsorg71 closed this Apr 19, 2023
@jsorg71 jsorg71 deleted the sesman_trans branch April 19, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants