Fixed possible SIGCHILD signal lost

[zbstao]

When multiple(eg. 20) xrdp connections are disconnected at the same time(eg. close all rdp client at the same time), zombie process will be spawned.
use xorgrdp session and set the parameter KillDisconnected to true.

I found similar code in file chansrv.c

void
child_signal_handler(int sig)
{
    int pid;

    LOG_DEVEL(LOG_LEVEL_INFO, "child_signal_handler:");
    do
    {
        pid = g_waitchild();
        LOG_DEVEL(LOG_LEVEL_INFO, "child_signal_handler: child pid %d", pid);
        if ((pid == g_exec_pid) && (pid > 0))
        {
            LOG_DEVEL(LOG_LEVEL_INFO, "child_signal_handler: found pid %d", pid);
            //shutdownx();
        }
    }
    while (pid >= 0);
}

[matt335672]

Hi @zbstao,

Thanks for your useful contribution. I've got a couple of comments relating to the coding style we use, but the functionality looks fine to me.

If you address the comments I'll enable the CI pipeline for the PR.

Thanks.

[matt335672]

The coding style requires spaces for indents rather than tabs, and also needs braces for the empty loop (e.g.):-

while(...)
{
}

I'm happy with the removal of the safety variable. It was introduced in f763cb3 but doesn't seem to be necessary.

[zbstao]

sorry didn't say the coding style page, the code needs to be modified.

[matt335672]

The while on the same line matches the coding style, but will be rejected by our use of astyle in the CI pipeline. Please can you place the while on a separate line?

[zbstao]

yes

[matt335672]

Nearly there, but you've used a tab instead of 4 spaces in both locations. The CI still won't like that.

Apologies if I wasn't clear.

[matt335672]

Looks great.

Can you squash your commits? I'll merge it in then.

[zbstao]

hi @matt335672
Done. In addition I will read the coding style asap.

[matt335672]

Thanks for your contribution @zbstao