Fixes MSTSC resize issue/crash #2291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RFX compression mode requires an encoder. When you resize RFX, you have to recreate the encoder. This will fix it as well: neutrinolabs#2175, however, that PR is bigger and more complex and may take longer.
|
Thanks! This can be applied to v0.9. |
|
@metalefty Did you test it and confirm you could:
As the bug is a little tricky to reproduce, I want to make sure someone else confirms before I merge this. |
|
@matt335672 Take a look! |
|
At least I could reproduce the crash 100% (3/3). I'll confirm the fix later. |
|
@Nexarian Confirmed the patch fixes the crash. |
|
Going to merge this in then. |
|
Can you raise a PR to make the same change to v0.9 branch? |
Nexarian
added a commit
to Nexarian/xrdp
that referenced
this pull request
Jun 27, 2022
Ports neutrinolabs#2291 to v0.9
|
Haven't tested it. Take a look! |
Nexarian
added a commit
to Nexarian/xrdp
that referenced
this pull request
Jun 27, 2022
Ports neutrinolabs#2291 to v0.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RFX compression mode requires an encoder. When you resize RFX, you have to recreate the encoder.
This will fix it as well: #2175, however, that PR is bigger and more complex and may take longer.
Fixes #1928