adding large cursor support #2315
Conversation
|
@jsorg71 - I'll try to get a look at this next week sometime, |
|
Take your time, I still have to add xup and xorg bits |
|
@jsorg71 Does this mean clean looking hidpi cursor support is coming online with this patch? Doing the lords work if so, I have been meaning to look into hidpi support for the cursor. |
libxrdp/xrdp_caps.c
Outdated
| caps_count++; | ||
| out_uint16_le(s, CAPSETTYPE_LARGE_POINTER); | ||
| out_uint16_le(s, CAPSETTYPE_LARGE_POINTER_LEN); | ||
| out_uint16_le(s, 1); /* LARGE_POINTER_FLAG_96x96 */ |
There was a problem hiding this comment.
Can we add this to ms-rdpbcgr.h ? Something like #define LARGE_POINTER_FLAG_96x96 1? It just helps when searching the code.
|
One very minor comment added. There's also the VNC module. I'm not suggesting you tackle this now, but when we merge this it might be worth adding a feature request to update that too. |
|
Just FYI, there are two types of large pointer updates: The one that you implemented here (for handling up to 96x96 bitmaps) and there is another one that allows handling for bitmaps up to 384x384 pixels ( |
|
BTW, I simple was to get large cursors is to |
|
@matt335672 I went to add large cursor to libvnc and seen it does not even support new cursors yet. I think lets do a todo for this so some can enjoy large cursors with xorg backend. |
|
Definitely - there's no need to hold this one up. When we merge this one, we can just add a feature request for VNC large cursors. |
No description provided.