Fix build with devel logging, but without --enable-pixman #3106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If ./configure is used with devel logging, but without --enable-pixman, the stub pixman development files are used. However, in this configuration, the pixman_region_selfcheck() function is declared, but not defined. This is a regression introduced in 7e58209
|
My mistake on the regression - both v0.9 and V0.10 are fine. The regression was introduced in 5eed76f (2023-10-20) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mentioned in #3105 as an observation.
If
./configureis used with devel logging, but without--enable-pixman, the stub pixman development files are used.However, in this configuration, the
pixman_region_selfcheck()function is declared, but not defined.Fix is to add a function definition in this situation.
This is a regression introduced in 7e58209