Fix evdev keycode problems #3113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6257dae added a mapping of RDP scancodes to X11 keycodes to the XUP interface. The intention is to move this functionality from xorgxrdp to a common lookup in xrdp. The mapping of RDP scancodes for extended keys (e.g. Right-CTRL) is not being done correctly.
The current fastpath code for scancode events is not mapping the FASTPATH_INPUT_KBDFLAGS_EXTENDED1 flag to the KBDFLAGS_EXTENDED1 flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 6257dae added a way to send an evdev X11 keycode to xorgxrdp. The interface is currently unused, but there are plans to do use it soon - see neutrinolabs/xorgxrdp#303
This PR fixes a couple of problems with the interface which have been uncovered during informal testing.