fix misuse of hidelogwindow #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metalefty
reviewed
Sep 14, 2017
xrdp/xrdp_wm.c
Outdated
| if (self->session->client_info->rdp_autologin || self->hide_log_window) | ||
| /* fix black screen if hidelogwindow=yes in xrdp.ini, only the log window should be hidden. not everything */ | ||
| /* https://github.com/neutrinolabs/xrdp/issues/414 */ | ||
| /*if (self->session->client_info->rdp_autologin || self->hide_log_window)*/ |
There was a problem hiding this comment.
The fix seems good but don't leave the old code in comment. You can just remove it.
There was a problem hiding this comment.
should I remove all other comments or leave them in place?
There was a problem hiding this comment.
I think no comments needed there.
cocoon
force-pushed
the
2017-09-14-fix-misuse-hidelogwindow
branch
from
1d27f7d
to
504f1e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix black screen if hidelogwindow=yes
#414