Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to pyproject.toml #54

Merged
merged 9 commits into from
Jun 3, 2024
Merged

Move to pyproject.toml #54

merged 9 commits into from
Jun 3, 2024

Conversation

ktactac-ornl
Copy link
Contributor

@ktactac-ornl ktactac-ornl commented Jun 3, 2024

Short description of the changes:

Moves from setup.py to pyproject.toml for conda packaging

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

5299: [Story] Update pystog packaging description

@ktactac-ornl ktactac-ornl marked this pull request as ready for review June 3, 2024 06:45
@Kvieta1990 Kvieta1990 merged commit 8de715d into master Jun 3, 2024
1 check passed
@Kvieta1990 Kvieta1990 deleted the create-conda-packaging branch June 3, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants