Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bringing v3.0 to master #413

Merged
merged 127 commits into from
Jan 18, 2023
Merged

Bringing v3.0 to master #413

merged 127 commits into from
Jan 18, 2023

Conversation

aaitor
Copy link
Member

@aaitor aaitor commented Nov 21, 2022

Description

  • NFT721Upgreadable refactor and new POAP implementation
  • Adding immutable url to include reference to Metadata on immutable storage networks
  • latest oz + linting
  • Adding proxy approval
  • Tests using the proxyApproval before NFT transfers now they are blocked
  • using 8545 port
  • Using hooks to protect transfers
  • using latest solidity compiler v0.8.17
  • ignoring unreachable OpenZeppelin warnings
  • Removing unnecessary setApprovalForAll to conditions because they are now managed via proxy permissions
  • Allowing to clone ERC 721 and 1155 NFT implementations
  • Removing NFTUpgreadable to NFT1155Upgreadable
  • Moving addMinter to NFTBase class and adding revokeMinter function
  • Updated NFT permissions
  • Updated DID permissions

Is this PR related with an open issue?

Related to Issue https://github.com/nevermined-io/contracts/milestone/4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

Funny gif

Put a link of a funny gif inside the parenthesis-->

New ERC-721 NFT implementation and POAP reference implementation refactor
Adding immutable url to include reference to Metadata on immutable storage networks
NFTs only can be transferred going through the service agreements
Removing unnecessary `setApprovalForAll` to conditions because they are now managed via proxy permissions
@aaitor aaitor modified the milestones: Contracts 2.2, Contracts 3.0 Jan 11, 2023
@aaitor aaitor merged commit 414066a into master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants