Use Iterable instead of Seq for MapRecords (#11) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
=======================================
Coverage 97.76% 97.76%
=======================================
Files 17 17
Lines 403 403
Branches 9 9
=======================================
Hits 394 394
Misses 9 9
Continue to review full report at Codecov.
|
|
Awesome thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maps which need to be mapped via an implicit conversion (e.g.String => Array[Byte]), or contain different case classes (even if they share the same structure: e.g. mapping fromMap[String, X]toMap[String, Y]whereX(a: Int)andY(a: Int)), do not compile.I've tried to track down the cause, with no success so far. Nevertheless, this is not a problem for me right now, so if you don't mind I'll open a different issue for that.
Closes #11