Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken in rubocop 0.25 #19

Closed
DanielHeath opened this issue Aug 21, 2014 · 7 comments
Closed

Broken in rubocop 0.25 #19

DanielHeath opened this issue Aug 21, 2014 · 7 comments
Labels

Comments

@DanielHeath
Copy link

Upgraded to the new rubocop release 0.25; got the following errors:

no implicit conversion of String into Integer
/Users/daniel.heath/Projects/rea/atlas/.bundle/gems/rubocop-rspec-1.1.0/lib/rubocop/cop/rspec/file_name.rb:45:in `[]'
For /Users/daniel.heath/Projects/rea/atlas: configuration from /Users/daniel.heath/Projects/rea/atlas/.rubocop.yml
undefined local variable or method `path' for RuboCop::RSpec::Inject:Module
/Users/daniel.heath/Projects/rea/atlas/.bundle/gems/rubocop-rspec-1.1.0/lib/rubocop/rspec/inject.rb:16:in `defaults!'
/Users/daniel.heath/Projects/rea/atlas/.bundle/gems/rubocop-rspec-1.1.0/lib/rubocop-rspec.rb:9:in `<top (required)>'
/Users/daniel.heath/Projects/rea/atlas/.bundle/gems/rubocop-0.25.0/lib/rubocop/config_loader.rb:43:in `require'
@geniou
Copy link
Collaborator

geniou commented Aug 23, 2014

Thanks for reporting the bug. I'm going to have a look.

@geniou
Copy link
Collaborator

geniou commented Sep 1, 2014

@DanielHeath can you show me your configuration? Especially for the RSpec/FileName cop.

@geniou geniou closed this as completed in 1bca049 Sep 2, 2014
@geniou
Copy link
Collaborator

geniou commented Sep 2, 2014

As a fix / workaround I renamed FileName cop into FilePath. Can you confirm that is is working for you now?

@geniou
Copy link
Collaborator

geniou commented Sep 2, 2014

Just for future reference the change in rubocop, that caused this bug: rubocop/rubocop@13d473b

@pkuczynski
Copy link

I can confirm this works now with latest Rubocop 0.26.0

@DanielHeath
Copy link
Author

Fixed for me too, thanks so much :)

@geniou
Copy link
Collaborator

geniou commented Sep 4, 2014

@DanielHeath thanks for reporting the bug and useing RuboCop RSpec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants