Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint: indent switch statements #1725

Merged
merged 1 commit into from Sep 16, 2019
Merged

eslint: indent switch statements #1725

merged 1 commit into from Sep 16, 2019

Conversation

AprilSylph
Copy link
Member

because unindented switch statements look bad and i dont like them

@nightpool
Copy link
Member

i thought about this when i was writing the eslint config but ultimately you gotta do the memes

@AprilSylph
Copy link
Member Author

:(

hobinjk
hobinjk approved these changes Sep 16, 2019
View reviewed changes
Copy link

@hobinjk hobinjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a slippery slope to requiring every case to be a {} block

@AprilSylph
Copy link
Member Author

worth the risk

@AprilSylph AprilSylph merged commit 76e59e0 into new-xkit:master Sep 16, 2019
@AprilSylph AprilSylph deleted the fix/switch-case-indents branch September 16, 2019 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hobinjk hobinjk hobinjk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AprilSylph @nightpool @hobinjk