Update __init__.py

[ejonesnospam]

Adds media controls. Improves error control for send_key commands

[newAM]

I am a little confused by this, what is raising the JSONDecodeError? Is this something that can be fixed elsewhere?

[ejonesnospam]

Hmm, well. I have absolutely no idea where that came from... lol.
That line should just be "except:"

[newAM]

What exception is getting raised there? It would be better to scope it down a little, a bare except will catch system level events like KeyboardInterrupt and SystemExit.

[ejonesnospam]

I'd have to defer to you here, as my best practices knowledge on exception handling is limited.

[newAM]

Generally I try to propagate exceptions as much as possible to the user - unless the exceptions are errors due to the internal code rather than a device malfunction or user error.

If this is an internal code error it would be helpful to know what causes it so that we could perhaps change the internal workings to function better, and limit the scope to capture just the exception(s) that are problematic. Are there any specific exceptions that you have had? Do you have the traceback for them?

[ejonesnospam]

No, I experienced no exceptions in my development. My thought process was to always return a bool value, based on success of send_key command. Any exception failure would be captured and appropriate return value sent.

[newAM]

I committed some changed to your branch - I narrowed the scope of the exception catching for JSON to just the JSONDecodeError, and removed the catch for _send_key exceptions.

I would prefer that _send_key propagate exceptions up to the user so that in case of problems that could be fixed by the user they get all the information instead of a True / False.

Let me know what you think!

Sorry for the slow replies, the coronavirus has made my life a little crazy recently.

[ejonesnospam]

No reason to apologize, if your community is not at or near chaos right now, you must be living in space.

I can totally agree understand that _send_key may should remain as is. After looking at again, I agree the exceptions are better if propagated up.
To allow more functionality, would it be better to include a template public command in the api, like below? Since the MQTT interface is not really supported publicly by Hisense, any future firmware change could alter or add more commands, and a fix may not require an API change (if lucky).
def send_key_template(self, keyname: str):
"""
Sends a keypress to the TV, as if it had been pressed on the IR remote.
Args:
keyname: Name of the key press to send.
"""
self._call_service(service="remote_service", action="sendkey", payload=keyname)

[newAM]

Nothing is every truly private in python so someone could just overwrite the private _send_key, maybe we should make it public?

class MyTv(HisenseTv):
    def _send_key(self, keyname: str):
        self._call_service(service="remote_service", action="new_sendkey_action", payload=keyname)

[ejonesnospam]

Yes, I feel it should be public. Also updated README for new media control commands. How do you like the nomenclature: "fast_forward" , "rewind", "volume_up" ?

[newAM]

Looks good to me! Should I merge now?

[ejonesnospam]

Yes, please. Stay safe

…

On Apr 5, 2020 at 11:06 AM, Alex ***@***.***> wrote: Looks good to me! Should I merge now? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[ejonesnospam]

Can you please update PyPi so I can download version 0.0.7