IO Optimizations #442
Merged
IO Optimizations #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Thanks for making the changes! I'll take a look through the code and provide feedback if necessary. My initial run through some of the tutorials with the Lite looks great. |
alex-dewar
reviewed
May 31, 2023
| @@ -27,7 +27,7 @@ | |||
| from ...common.utils import util | |||
| from ._base import AcqKeyTextPattern_Base | |||
| from ...common.utils.util import camel_case_deprecated | |||
| bytearray = util.bytearray # type: ignore | |||
| bytearray = util.CWByteArray # type: ignore | |||
There was a problem hiding this comment.
Lines 190 and 209 are using util.bytearray(), which needs to be changed to bytearray()
There was a problem hiding this comment.
Fixed! Also grepped the project for other similar instances and fixed those, as well.
DJShepherd
force-pushed
the
DJShepherd/io_performance
branch
from
467aff7
to
d3f8ec1
Compare
…AEUSB and serial interfaces and simplified API; Simplified OpenADCInterface sendMessage API; Renamed bytearray subclass to CWByteArray to prevent type confusions with builtin functions
DJShepherd
force-pushed
the
DJShepherd/io_performance
branch
from
d3f8ec1
to
bf754af
Compare
|
Code looks good and seems to run fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passed all tests/test_api.py and ran the clock glitch demo on CWLITE.