Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Config): Add option to enable some part for the editor #357

Merged
merged 5 commits into from
Jan 24, 2024

Conversation

starker-xp
Copy link
Contributor

@starker-xp starker-xp commented Jan 5, 2024

The goal is to be able to disable certain parts of the editor.

@newcat
Copy link
Owner

newcat commented Jan 14, 2024

Unfortunately, I had to revert the changes to the minimap settings, since they would be breaking (even though that would be the nicer solution)

@starker-xp
Copy link
Contributor Author

Where did you find the breaking changes? Let me correct it.

@newcat
Copy link
Owner

newcat commented Jan 24, 2024

The breaking change was removing the enableMinimap property. I thought I may be able to find a way to keep the property while also having the minimap.enabled property and have them synced, but so far I wasn't able to get it working with Vue's reactivity system. I'm going to merge this PR now and maybe I'll find something in the future.

@newcat newcat merged commit 3d0355b into newcat:master Jan 24, 2024
@starker-xp
Copy link
Contributor Author

Ok I see, I'll try on my side and I'll make a PR if I find it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants