Topic missing on connection's header generate error #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vent errors (header topic is missing on ros noetic rosbags)
|
Sigh... It's what we get when a format does not have a proper specification. Looking at this issue it looks like |
|
Thank you! This fix is released in v0.6.3. |
|
And thanks to you too ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On ROS Noetic rosbags, the header
topicis missing in connection's headers.I don't know if it's related to https://answers.ros.org/question/266967/why-does-rosbag_storage-add-topic-to-the-connection-header/ but this MR seems to fix the problem.
Note that in this library, the header is get from the record and not the connection's headers :
https://github.com/swri-robotics/bag-reader-java/blob/master/src/main/java/com/github/swrirobotics/bags/reader/records/Connection.java#L54C9-L54C16