Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Change New Relic 'require' with 'import' #13

Conversation

christianvuerings
Copy link
Contributor

Changes

Replaces the New Relic require with import

Why

We use import everywhere else in the file

@christianvuerings
Copy link
Contributor Author

@matewilk would you be able to take a look?

@matewilk matewilk merged commit 3425b9e into newrelic-experimental:main Feb 21, 2023
@matewilk
Copy link
Collaborator

Thanks @christianvuerings

@josephmarkus
Copy link

@christianvuerings FYI same here and here

@matewilk
Copy link
Collaborator

matewilk commented Mar 9, 2023

Here you go @josephmarkus #15

The PR requires a bit more testing so it might take a few days before it's merged, but you can copy->paste bits and pieces if you need to to your repo. (might not work depending on your setup, the dynamic import in _error.tsx file causes some issues)

@josephmarkus
Copy link

@matewilk thanks! I did notice that await import in _error.tsx explodes on yarn build complaining about a bunch of missing modules etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants