(update): replace require with import & update libs to latest versions #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matewilk
commented
Mar 9, 2023
| const newrelic = require("newrelic"); | ||
| // use dynamic import to avoid typescript error | ||
| // https://2ality.com/2017/01/import-operator.html | ||
| const newrelic = await import("newrelic"); |
There was a problem hiding this comment.
This doesn't seem to be working with the current setup.
It might be because there are some left overs from a nextjs custom server and babel configs.
There was a problem hiding this comment.
all good, it was my mistake, put the comment for myself really to remember to check some things :)
|
This PR requires more diligent testing to confirm all the New Relic features work as expected, especially Codestream & code-level metrics. |
matewilk
changed the title
bizob2828
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.