Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect and sample the top processes #41

Merged
merged 1 commit into from
Oct 12, 2018

Conversation

binaryseed
Copy link
Contributor

This PR adds a new sampler that will detect the top processes (according to memory & message queue length) and report on them

Also

  • A few tweaks to the other process sampler to make it safer
  • Randomize the start of each of the samplers so they all don't run at once

mattbaker
mattbaker previously approved these changes Oct 10, 2018
@binaryseed
Copy link
Contributor Author

Had to rebase @mattbaker

@sb8244
Copy link
Contributor

sb8244 commented Oct 10, 2018

@binaryseed where will these show up in New Relic? Really love this feature but I'm not sure how I'd find the info in NR.

@binaryseed
Copy link
Contributor Author

It's all based on Insights events, so right now it's visible via dashboards.

However, I'm working on a BEAM page for elixir apps, which will display all this inside APM :)

@binaryseed binaryseed merged commit c3e20f8 into newrelic:master Oct 12, 2018
@binaryseed binaryseed deleted the top-proc branch October 12, 2018 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants