Data race in RoundTripper

[blixt]

These lines run for every individual round trip:

go-agent/instrumentation.go

Lines 85 to 87 in 8927200

	if nil == original {
	original = http.DefaultTransport
	}

This means a data race can be triggered for two parallel requests using this RoundTripper. I don't think this is very harmful in this case since they always write the same value so even though it's indeterministic which write will be read, the value will be the same.

This still triggers Go's data race warnings so it's quite noisy and I would recommend moving these lines to the outer scope to fix the issue.

[purple4reina]

@blixt Thanks so much for reporting this. That is indeed a problem. We'll get it fixed as soon as we can.

Take good care,
Rey

[purple4reina]

Hey @blixt . We will be including a fix for this in our next release. Thanks again for reporting it.

[newrelic-eheinlein]

Hi @blixt ! We have released version 3.6.0 today, and it includes a fix for this issue. Thanks again for reporting it! I'll close the issue now but let us know if you see any additional problems.