Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nrecho skipper patch #521

Merged
merged 3 commits into from
Jul 6, 2022
Merged

Conversation

iamemilio
Copy link
Contributor

@iamemilio iamemilio commented Jun 27, 2022

main-author: @prashanthpai

prashanthpai and others added 3 commits June 27, 2022 10:49
Users can now specify a skipper function which will be called by the
nrecho middleware to check if the middleware should be bypassed.

This is implemented along the lines of Skipper functionality provided by
middlewares in echo:
https://github.com/labstack/echo/blob/master/middleware/middleware.go#L15
https://github.com/labstack/echo/blob/master/middleware/logger.go#L110

Signed-off-by: Prashanth Pai <prashanth.pai@unacademy.com>
@iamemilio iamemilio marked this pull request as ready for review July 6, 2022 13:31
@iamemilio iamemilio merged commit 7ea5bd3 into newrelic:develop Jul 6, 2022
@iamemilio iamemilio deleted the nrecho-skipper-patch branch July 6, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants