Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: integrations v4 naming #112

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Refactor: integrations v4 naming #112

merged 1 commit into from
Sep 21, 2020

Conversation

varas
Copy link
Contributor

@varas varas commented Sep 21, 2020 •
edited
Loading

Simply renaming files and vars so they are more easy to grasp.

@varas varas requested a review from a team September 21, 2020 07:47
@coveralls
Copy link

Pull Request Test Coverage Report for Build 264709240

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 58.417%
Files with Coverage Reduction New Missed Lines %
internal/agent/event_sender_vortex.go 1 73.21%
pkg/metrics/sampler/sampler_routine.go 2 94.74%
Totals Coverage Status
Change from base Build 259396931: 0.0%
Covered Lines: 11084
Relevant Lines: 18974
💛 - Coveralls

noly
noly approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@noly noly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@varas varas merged commit c0126c7 into master Sep 21, 2020
@varas varas deleted the refactor/v4_naming branch September 21, 2020 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noly noly noly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@varas @coveralls @noly