Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #33

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Update README.md #33

merged 1 commit into from
Jul 3, 2020

Conversation

theletterf
Copy link

Description of the changes

Add a detailed description and purpose of your changes.
Link the issue it solves (if there is one).

PR Review Checklist

Author

  • the PR should focus on a single subject. Change only relevant files to the problem you’re working on
  • clean and format the code
  • add unit tests for your changes and make sure all unit tests are passing
  • add a risk label after carefully considering the "blast radius" of your changes
  • describe the intent of your changes in the description. don't just rewrite your code in prose
  • assign at least one reviewer
  • address the feedback
  • add a "ready for review" label. Only PRs with this label will be reviewed.

Reviewer

  • review code for readability
  • verify that high risk behavior changes are well tested
  • check license for any new external dependency
  • ask questions about anything that isn't clear and obvious
  • approve the PR when you consider it's good to merge

@varas varas merged commit a36c382 into newrelic:master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants