Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace non dimensional metrics payload submissions #589

Merged
merged 4 commits into from
Jun 28, 2021

Conversation

varas
Copy link
Contributor

@varas varas commented Jun 25, 2021

Add a trace to log non dimensional metrics payload submissions to NewRelic platform.

This trace is disabled by default, it should be enabled as defined below.

Docs

Public link: https://docs.newrelic.com/docs/infrastructure/install-infrastructure-agent/configuration/infrastructure-agent-configuration-settings/#debug-variables

Example: https://github.com/newrelic/infrastructure-agent/blob/master/assets/examples/infrastructure/newrelic-infra-template.yml.example#L704

Usage

Via YAML config:

trace:
- v3.submission

Or env-var:

NRIA_TRACE="v3.submission"

@varas varas requested a review from a team June 25, 2021 15:36
@varas varas changed the title feat: trace non dimensional metrics payload submissions Trace non dimensional metrics payload submissions Jun 25, 2021
@varas
Copy link
Contributor Author

varas commented Jun 28, 2021

Related to #339

@@ -679,7 +679,7 @@ type Config struct {

// FeatureTraces enables traces (verbose logs) for a given set of features, aimed to troubleshoot issues, available
// features at trace/features.go
// Default: Empty
// Default: "connect"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tikismikis comment of the day : ["connect"] ;-)

Copy link
Contributor

@rubenruizdegauna rubenruizdegauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varas varas merged commit 7a51d58 into master Jun 28, 2021
@varas varas deleted the feat/trace-non-dm-submissions branch June 28, 2021 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants