Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Automate code coverage reports #26

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

juanjjaramillo
Copy link
Contributor

Description

Automate code coverage reports for unit testing

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

Copy link

codecov bot commented May 16, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@juanjjaramillo juanjjaramillo marked this pull request as ready for review May 16, 2024 21:16
@juanjjaramillo juanjjaramillo requested a review from a team May 16, 2024 21:16
@juanjjaramillo juanjjaramillo merged commit 67cbd28 into main May 16, 2024
9 checks passed
@juanjjaramillo juanjjaramillo deleted the juanjjaramillo/codecov branch May 16, 2024 22:29
paologallinaharbur pushed a commit to paologallinaharbur/k8s-agents-operator that referenced this pull request Sep 6, 2024
* feat: NR-121867 Supervisor traits, infra supervisor

* refactor: supervise just one process, wait and kill inside run

* Add Graceful shutdown to supervisor (newrelic#26)

* chore: cleanup

* test: kill process with the terminator

* test: scope process termination to unix

* feat: return another type for run

test: move to integration

* test: deactivate miri

* chore: clippy suggestions, typos

* feat: default impl for SupervisorContext

* chore: cleanup run function and supervisorrunner

* refactor: use from attribute to provide impls

* test: remove supervisor mod test (now integration)

* refactor: unify types, go full typestate

* feat: define stop and Supervisor state

* refactor: make ProcessRunner.process private

* docs: remove unneeded, change docs for stop method

---------

Co-authored-by: Alvaro Cabanas <acabanas@newrelic.com>
Co-authored-by: Roger Coll <rogercoll@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants