Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add pullPolicy to values in Helm charts #29

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

TimPansino
Copy link
Contributor

@TimPansino TimPansino commented May 23, 2024

Description

  • Adds controllerManager.manager.image.pullPolicy to template values in Helm to allow use of locally built copies of the operator for testing. Defaults to Always like it was before.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

@TimPansino TimPansino requested a review from a team May 23, 2024 21:20
@TimPansino TimPansino changed the title Add pullPolicy to values in Helm charts feat: Add pullPolicy to values in Helm charts May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.43%. Comparing base (dbe3049) to head (cb55adf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   47.43%   47.43%           
=======================================
  Files          13       13           
  Lines         976      976           
=======================================
  Hits          463      463           
  Misses        448      448           
  Partials       65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanjjaramillo juanjjaramillo merged commit 474516b into main Jun 10, 2024
10 checks passed
@juanjjaramillo juanjjaramillo deleted the feature-pullpolicy-for-chart branch June 10, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants