fix: Remove webpack imports in npm package (#925)

babel.config.js

@@ -45,15 +45,7 @@ module.exports = function (api, ...args) {
       ]
     },
     webpack: {
-      ignore,
-      plugins: [
-        [
-          './tools/babel/plugins/transform-import',
-          {
-            '(constants/)env$': '$1env.cdn'
-          }
-        ]
-      ]
+      ignore
     },
     'webpack-ie11': {
       ignore,
@@ -73,15 +65,6 @@ module.exports = function (api, ...args) {
             }
           }
         ]
-      ],
-      plugins: [
-        [
-          './tools/babel/plugins/transform-import',
-          {
-            '(constants/)env$': '$1env.cdn',
-            'polyfill-detection$': 'polyfill-detection.es5'
-          }
-        ]
       ]
     },
     'npm-cjs': {
@@ -97,9 +80,7 @@ module.exports = function (api, ...args) {
         [
           './tools/babel/plugins/transform-import',
           {
-            '(/constants/|^\\./)env$': '$1env.npm',
-            '(/configure/|^\\./)public-path$': '$1public-path.npm',
-            '(/configure/|^\\./)nonce$': '$1nonce.npm'
+            '(/constants/|^\\./)env$': '$1env.npm'
           }
         ]
       ]
@@ -117,9 +98,7 @@ module.exports = function (api, ...args) {
         [
           './tools/babel/plugins/transform-import',
           {
-            '(/constants/|^\\./)env$': '$1env.npm',
-            '(/configure/|^\\./)public-path$': '$1public-path.npm',
-            '(/configure/|^\\./)nonce$': '$1nonce.npm'
+            '(/constants/|^\\./)env$': '$1env.npm'
           }
         ]
       ]

src/loaders/configure/nonce.cdn.js

@@ -0,0 +1,12 @@
+/* global __webpack_require__ */
+
+__webpack_require__.nc = (() => {
+  try {
+    return document?.currentScript?.nonce
+  } catch (ex) {
+    // Swallow error and proceed like nonce is not defined
+    // This will happen when the agent is loaded in a worker scope
+  }
+
+  return ''
+})()

src/loaders/configure/nonce.js

@@ -1,12 +1 @@
-/* global __webpack_require__ */
-
-__webpack_require__.nc = (() => {
-  try {
-    return document?.currentScript?.nonce
-  } catch (ex) {
-    // Swallow error and proceed like nonce is not defined
-    // This will happen when the agent is loaded in a worker scope
-  }
-
-  return ''
-})()
+// We don't support setting automating the nonce attribute in the npm package

src/loaders/configure/public-path.cdn.js

@@ -0,0 +1,9 @@
+// Set the default CDN or remote for fetching the assets; NPM shouldn't change this var.
+
+export const redefinePublicPath = (urlString) => {
+  const isOrigin = urlString.startsWith('http')
+  // Input is not expected to end in a slash, but webpack concats as-is, so one is inserted.
+  urlString += '/'
+  // If there's no existing HTTP scheme, the secure protocol is prepended by default.
+  __webpack_public_path__ = isOrigin ? urlString : 'https://' + urlString // eslint-disable-line
+}

src/loaders/configure/public-path.js

@@ -1,9 +1,3 @@
-// Set the default CDN or remote for fetching the assets; NPM shouldn't change this var.
-
-export const redefinePublicPath = (urlString) => {
-  const isOrigin = urlString.startsWith('http')
-  // Input is not expected to end in a slash, but webpack concats as-is, so one is inserted.
-  urlString += '/'
-  // If there's no existing HTTP scheme, the secure protocol is prepended by default.
-  __webpack_public_path__ = isOrigin ? urlString : 'https://' + urlString // eslint-disable-line
+export const redefinePublicPath = () => {
+  // We don't support setting public path in webpack via NPM build.
 }

tools/webpack/configs/common.mjs

@@ -87,7 +87,16 @@ export default (env, asyncChunkName) => {
       new NRBARemoveNonAsciiPlugin(),
       new NRBALoaderApmCheckPlugin(),
       new NRBASubresourceIntegrityPlugin(),
-      new NRBAFuzzyLoadersPlugin()
+      new NRBAFuzzyLoadersPlugin(),
+      new webpack.NormalModuleReplacementPlugin(/(?:[\\/]constants)?[\\/]env/, (resource) => {
+        resource.request = resource.request.replace(/env$/, 'env.cdn')
+      }),
+      new webpack.NormalModuleReplacementPlugin(/(?:[\\/]configure)?[\\/]public-path/, (resource) => {
+        resource.request = resource.request.replace(/public-path$/, 'public-path.cdn')
+      }),
+      new webpack.NormalModuleReplacementPlugin(/(?:[\\/]configure)?[\\/]nonce/, (resource) => {
+        resource.request = resource.request.replace(/nonce$/, 'nonce.cdn')
+      })
     ]
   }
 }

tsconfig.json

@@ -10,5 +10,12 @@
     "skipLibCheck": true
   },
   "include": ["src/**/*"],
-  "exclude": ["**/*.test.js", "**/*.component-test.js","**/__mocks__/*.js"]
+  "exclude": [
+    "**/*.test.js",
+    "**/*.component-test.js",
+    "**/__mocks__/*.js",
+    "src/common/config/env.cdn.js",
+    "src/loaders/configure/nonce.cdn.js",
+    "src/loaders/configure/public-path.cdn.js"
+  ]
 }